Feature: add gpt oss and qwen3 models to kvbench #1108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheese-head
requested review from
aranadive,
brminich and
ovidiusm
as code owners
aranadive
reviewed
Dec 11, 2025
| # SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); |
Contributor
There was a problem hiding this comment.
You can shorten the license to the first two lines only:
SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved# SPDX-License-Identifier: Apache-2.0
aranadive
reviewed
Dec 11, 2025
| kv_size = int(kv_size / self.num_layers) | ||
| if kv_size <= 0: | ||
| raise ValueError("Invalid KV Size: 0") | ||
|
|
Contributor
There was a problem hiding this comment.
Fix the extra spacing issue here and others below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Added support for Qwen3 and GPT-OSS model configurations in kvbench
How?
Added Qwen3 model configurations
Added GPT-OSS model configurations