fix(rust-bindings): detect NIXL availability and fallback to stubs #1120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use built-in compiler types in wrapper.h instead of system headers (stdbool.h, stddef.h, stdint.h) to fix bindgen failures on systems where libclang cannot locate standard headers - Add check_nixl_available() to detect if NIXL library is installed by checking pkg-config and common library paths for libnixl.so - Fallback to stub API when NIXL is not found, with clear warning: "NIXL library not found, building with stub API" This allows the Rust bindings to build successfully on systems without NIXL installed, enabling development and testing of Rust code that depends on nixl-sys without requiring the full NIXL installation. Signed-off-by: Ryan Olson <[email protected]>
ryanolson
requested review from
gleon99,
mkhazraee and
roiedanino
as code owners
Contributor
|
/build |
milesial
reviewed
Dec 16, 2025
| let arch = get_arch(); | ||
|
|
||
| // Check various possible library locations | ||
| let possible_paths = [ |
Contributor
There was a problem hiding this comment.
Can the check for availability use the same set of paths that would be sent to the linker? We're missing 2 of the 5 right now. And maybe use the same function for both so they are always aligned
// Add all possible library paths
println!("cargo:rustc-link-search=native={}", nixl_lib_path);
println!("cargo:rustc-link-search=native={}", nixl_root_path);
println!("cargo:rustc-link-search=native={}/lib", nixl_root_path);
println!("cargo:rustc-link-search=native={}/lib64", nixl_root_path);
println!("cargo:rustc-link-search=native={}/lib/x86_64-linux-gnu", nixl_root_path);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use built-in compiler types in wrapper.h instead of system headers (stdbool.h, stddef.h, stdint.h) to fix bindgen failures on systems where libclang cannot locate standard headers
Add check_nixl_available() to detect if NIXL library is installed by checking pkg-config and common library paths for libnixl.so
Fallback to stub API when NIXL is not found, with clear warning: "NIXL library not found, building with stub API"
This allows the Rust bindings to build successfully on systems without NIXL installed, enabling development and testing of Rust code that depends on nixl-sys without requiring the full NIXL installation.