Skip to content

Conversation

@2dm
Copy link
Contributor

@2dm 2dm commented Dec 13, 2025

What?

This PR introduce updates to nixl-ep example:

  1. Updates from DeepEP library
  2. Use of channel API

@2dm 2dm requested a review from a team as a code owner December 13, 2025 03:45
@copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 13, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions
Copy link

👋 Hi 2dm! Thank you for contributing to ai-dynamo/nixl.

Your PR reviewers will review your contribution then trigger the CI to test your changes.

🚀

@2dm 2dm requested a review from itayalroy December 16, 2025 17:47
@itayalroy
Copy link
Contributor

Do we have some perf comparison between multiple workers single channel and single worker multiple channels?
I think it's worth to run some sanity at least to verify that this does not cause major degradations

Copy link
Contributor

@itayalroy itayalroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR does not reduce UCX backend's num_workers to 1

  • @eranrs this is why you probably did not see a huge benefit with it. The PR needs to be fixed & re-tested for control path perf

RoeyAzran1992 and others added 7 commits January 7, 2026 09:08
@brminich
Copy link
Contributor

brminich commented Jan 8, 2026

/ok to test

@copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 8, 2026

/ok to test

@brminich, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

@brminich
Copy link
Contributor

brminich commented Jan 8, 2026

/build

@brminich
Copy link
Contributor

brminich commented Jan 8, 2026

/ok to test 0b866f3

@itayalroy
Copy link
Contributor

Merged in #1175

@itayalroy itayalroy closed this Jan 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants