Add microbenchmarks #1140
Open
Add microbenchmarks #1140
+505
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi benlwalker! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
iyastreb
reviewed
Dec 17, 2025
The nixlTelemetryPlugin::getName() and getVersion() methods were returning std::string by value, creating temporary objects. The nixlTelemetryPluginHandle wrapper was calling .data() on these temporaries and returning the pointer, which became dangling once the temporary was destroyed. This bug was caught by GCC's -Werror=return-local-addr warning in release builds with optimizations enabled, causing compilation to fail. The methods now return references to member strings that remain valid for the lifetime of the plugin object, eliminating the dangling pointer. Signed-off-by: Ben Walker <[email protected]>
We are adding microbenchmarks to the test suite. These need to be compiled in release mode. Signed-off-by: Ben Walker <[email protected]>
benlwalker
force-pushed
the
ben/microbenchmarks
branch
from
31bb20d to
dd6a24d
Compare
benchmark Add a directory to be used for micro-benchmarks. The first benchmark added is for nixlAgent::makeXferReq Signed-off-by: Ben Walker <[email protected]>
benlwalker
force-pushed
the
ben/microbenchmarks
branch
from
dd6a24d to
42063b9
Compare
brminich
reviewed
Jan 8, 2026
| protected: | ||
| void | ||
| SetUp() override { | ||
| env_.addVar("NIXL_TELEMETRY_ENABLE", "n"); |
Contributor
There was a problem hiding this comment.
why is it needed? We may have other vars affecting perf, e.g. NIXL_LOG_LEVEL
(also it is disabled by default)
iyastreb
approved these changes
Jan 8, 2026
| @@ -0,0 +1,29 @@ | |||
| # SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | |||
Contributor
There was a problem hiding this comment.
pls update all copyrights to 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add a new gtest directory to hold microbenchmarks. Then add a new benchmark for nixlAgent::makeXferReq.
Why?
These will allow us to test the performance of isolated pieces of NIXL easily.
How?
This is a gtest based test. It runs like the other unit tests. I could have used Google Benchmark but I didn't want to pull in another dependency.