Skip to content

BACKEND/UCX: fix req initialization in checkXfer #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 25, 2025
Merged

BACKEND/UCX: fix req initialization in checkXfer #690

merged 5 commits into from
Aug 25, 2025

Conversation

@evgeny-leksikov
Copy link
Contributor

@evgeny-leksikov evgeny-leksikov commented Aug 15, 2025 •
edited by iyastreb
Loading

What?

Why?

How?

move connection lookup to a helper method getConnection and pass the result to notifSendPriv

@github-actions
Copy link

github-actions bot commented Aug 15, 2025

👋 Hi evgeny-leksikov! Thank you for contributing to ai-dynamo/nixl.

Your PR reviewers will review your contribution then trigger the CI to test your changes.

🚀

@evgeny-leksikov
Copy link
Contributor Author

evgeny-leksikov commented Aug 15, 2025

/build

yosefe
yosefe reviewed Aug 18, 2025
View reviewed changes
Copy link
Contributor

@yosefe yosefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this PR a bug fix? If yes can we add gtest?

@pull-request-size pull-request-size bot added size/L and removed size/M labels Aug 18, 2025
@evgeny-leksikov
Copy link
Contributor Author

evgeny-leksikov commented Aug 18, 2025

/build

@evgeny-leksikov
Copy link
Contributor Author

evgeny-leksikov commented Aug 18, 2025

is this PR a bug fix? If yes can we add gtest?

yes, but seems like this flow is not covered yet, I'll see how to improve

@evgeny-leksikov evgeny-leksikov requested a review from a team as a code owner August 19, 2025 08:32
yosefe
yosefe approved these changes Aug 25, 2025
View reviewed changes
Copy link
Contributor

@yosefe yosefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you pls rebase? the imported commits from main branch look weird

@evgeny-leksikov
Copy link
Contributor Author

evgeny-leksikov commented Aug 25, 2025

/build

1 similar comment
@roiedanino
Copy link
Contributor

roiedanino commented Aug 25, 2025

/build

@evgeny-leksikov evgeny-leksikov merged commit 1eb6e6b into ai-dynamo:main Aug 25, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iyastreb iyastreb iyastreb left review comments

@yosefe yosefe yosefe approved these changes

@roiedanino roiedanino roiedanino approved these changes

@ovidiusm ovidiusm Awaiting requested review from ovidiusm

@brminich brminich Awaiting requested review from brminich brminich is a code owner

@gleon99 gleon99 Awaiting requested review from gleon99 gleon99 is a code owner

@mkhazraee mkhazraee Awaiting requested review from mkhazraee

Assignees

No one assigned

Labels

external-contribution size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@evgeny-leksikov @iyastreb @roiedanino @yosefe