Removed progress method and its indicator from SB API. #701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkhazraee
requested review from
a team,
brminich,
gleon99 and
yosefe
as code owners
|
👋 Hi mkhazraee! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
mkhazraee
force-pushed
the
mkhazraee/prog_removal
branch
from
20d146c to
99c6cd8
Compare
mkhazraee
force-pushed
the
mkhazraee/prog_removal
branch
from
99c6cd8 to
1232e3e
Compare
Contributor
Author
|
/build |
mkhazraee
force-pushed
the
mkhazraee/prog_removal
branch
from
1232e3e to
2ea96b9
Compare
mkhazraee
force-pushed
the
mkhazraee/prog_removal
branch
from
66a7633 to
930c9f7
Compare
Contributor
Author
|
/build |
mkhazraee
force-pushed
the
mkhazraee/prog_removal
branch
from
930c9f7 to
9801900
Compare
Contributor
Author
|
/build |
mkhazraee
force-pushed
the
mkhazraee/prog_removal
branch
from
9801900 to
f4e91ca
Compare
Contributor
Author
|
/build |
tstamler
approved these changes
Aug 27, 2025
brminich
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removes progress() and supportsProgTh() from SB API. They can be still used within the plugin.
Why?
As ucx and gds_mt are already using multi-threads to deliver performance, idea of shared progress thread became less useful. Shared progress thread can also cause contention between the backends, while we want the isolation in modularity as much as possible. So team decided to remove it from the SB API. Plugins internally can still use it, such as current ucx implementation, just not a mandatory method in SB API anymore.