Skip to content

API/GPU/UCX: Create GPU-side Device API #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2025
Merged

API/GPU/UCX: Create GPU-side Device API #704

merged 1 commit into from
Aug 28, 2025
+162 −0

Conversation

michal-shalev
Copy link
Contributor

@michal-shalev michal-shalev commented Aug 20, 2025 •
edited
Loading

What?

Add GPU device function stubs for UCX backend with template-based coordination levels (thread, warp, block, grid) for memory transfers, signal transfers, and status checking.

Why?

To establish foundation for GPU-initiated transfers.
See also: #705

How?

Added 5 templated device functions in nixl_device.cuh that return NIXL_ERR_NOT_SUPPORTED as placeholders:
nixlGpuPostSingleWriteXferReq - memory transfers
nixlGpuPostSignalXferReq - signal transfers
nixlGpuPostPartialWriteXferReq - partial transfers
nixlGpuPostWriteXferReq - full transfers
nixlGpuGetXferStatus - status checking

@michal-shalev michal-shalev requested a review from a team as a code owner August 20, 2025 14:27
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Aug 20, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions GitHub Actions
Copy link

👋 Hi michal-shalev! Thank you for contributing to ai-dynamo/nixl.

Your PR reviewers will review your contribution then trigger the CI to test your changes.

🚀

@michal-shalev michal-shalev requested a review from yosefe August 20, 2025 14:28
@michal-shalev michal-shalev self-assigned this Aug 20, 2025
@michal-shalev michal-shalev mentioned this pull request Aug 20, 2025
Merged
brminich
brminich reviewed Aug 21, 2025
View reviewed changes
@michal-shalev michal-shalev force-pushed the create-device-api branch 3 times, most recently from 5c32b17 to 3d2a8a4 Compare August 24, 2025 14:26
@yosefe
Copy link
Contributor

yosefe commented Aug 25, 2025

/build

@michal-shalev michal-shalev changed the title API/CUDA/UCX: Create Device API API/GPU/UCX: Create Device API Aug 25, 2025
@yosefe
Copy link
Contributor

yosefe commented Aug 28, 2025

/build

@yosefe yosefe enabled auto-merge (squash) August 28, 2025 15:43
@michal-shalev
Copy link
Contributor Author

/build

@michal-shalev
API/GPU/UCX: Create Device API
e6c93d2 
Signed-off-by: Michal Shalev <[email protected]>
@michal-shalev
Copy link
Contributor Author

/build

@yosefe yosefe merged commit add1824 into ai-dynamo:main Aug 28, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yosefe yosefe yosefe approved these changes

@iyastreb iyastreb Awaiting requested review from iyastreb

@tvegas1 tvegas1 Awaiting requested review from tvegas1

@ovidiusm ovidiusm Awaiting requested review from ovidiusm

@tstamler tstamler Awaiting requested review from tstamler

@aranadive aranadive Awaiting requested review from aranadive

@mkhazraee mkhazraee Awaiting requested review from mkhazraee

@ofirfarjun7 ofirfarjun7 Awaiting requested review from ofirfarjun7

@ColinNV ColinNV Awaiting requested review from ColinNV

@rakhmets rakhmets Awaiting requested review from rakhmets

@brminich brminich Awaiting requested review from brminich

Assignees

@michal-shalev michal-shalev

Labels
external-contribution size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@michal-shalev @yosefe @ovidiusm @brminich @ofirfarjun7 @rakhmets @ColinNV