Remove has_overlaps method from descList as it is not used. #718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi mkhazraee! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
mkhazraee
force-pushed
the
mkhazraee/remove_overlaps
branch
from
0f52b5b to
679afa7
Compare
…re not used. It was planned for potential overlapping registrations, but it can be checked in register method through nixlBasicDesc overlaps method, instead of exposing it in the user facing nixlDescList.
mkhazraee
force-pushed
the
mkhazraee/remove_overlaps
branch
from
679afa7 to
d8907d9
Compare
|
/build |
roiedanino
approved these changes
Aug 24, 2025
yosefe
approved these changes
Aug 24, 2025
evgeny-leksikov
pushed a commit
to evgeny-leksikov/nixl
that referenced
this pull request
Aug 25, 2025
…re not used. (ai-dynamo#718) It was planned for potential overlapping registrations, but it can be checked in register method through nixlBasicDesc overlaps method, instead of exposing it in the user facing nixlDescList.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Remove has_overlaps method from descList.
Why?
Was planned for potential overlapping registrations, but it can be checked in register method instead of exposing the user facing descList.