Added TokenSigner interface to allow external sign algorithm to be used#61
Open
altissia-be wants to merge 1 commit intoaidantwoods:dev-v1.x.xfrom
Open
Added TokenSigner interface to allow external sign algorithm to be used#61altissia-be wants to merge 1 commit intoaidantwoods:dev-v1.x.xfrom
altissia-be wants to merge 1 commit intoaidantwoods:dev-v1.x.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I am using this library to sign Paseto tokens, but I wanted to use Google KMS to handle the key signature.
As GCP KMS does not allow reading the private key but only allows sending the payload to sign, I had to modify slightly the library to let the user provide a TokenSigner which will handle the signing instead of using
ed25519.Signdirectly.The modification is small, but I have only implemented the function for V4 tokens.
I am open to expand the implementation to older versions, as well as adapting the naming to something more sensible, if needed.