Allow specifying the ssh key for the tests and loosen fallbacks to default ssh key #6563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests were relying on `~/.ssh/id_rsa` to be used to allow ssh to localhost. This had the side effect that several tests specified a ssh key in their configuration that was then not working in the authentication but a fall back to the default ssh key still allowed a connection. This PR fixes this behaviour and uses also the ssh key specified for the connection. This also allows the user to specify a dedicated ssh key for aiida tests and does not enforce the usage of the default key.
agoscinski
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6563 +/- ##
==========================================
+ Coverage 77.51% 77.81% +0.30%
==========================================
Files 560 566 +6
Lines 41444 41988 +544
==========================================
+ Hits 32120 32667 +547
+ Misses 9324 9321 -3 ☔ View full report in Codecov by Sentry. |
agoscinski
changed the title
agoscinski
commented
Sep 11, 2024
| """Returns a SSH key for the test session. | ||
|
|
||
| If the environment variable ``AIIDA_PYTEST_SSH_KEY`` is set we take the key from this path otherwise we generate a | ||
| temporary SSH key pair for the test session and return the filepath of the private key. |
There was a problem hiding this comment.
Suggested change
| temporary SSH key pair for the test session and return the filepath of the private key. | |
| temporary SSH key pair for the test session and return the filepath of the private key. The temporary key cannot be used to connect to localhost as it is not authorized, therefore it is required that the default ssh key `~/.ssh/id_rsa`is authorized to connect to localhost to automatically fallback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to specify a ssh key that is used in the tests by the environment variable
AIIDA_PYTEST_SSH_KEY. Using~/.ssh/id_rsaas key and not specifying the environment variable still should work as the fallbacks should start to work.The tests were relying on
~/.ssh/id_rsato be used to allow ssh to localhost. This had the side effect that several tests specified a ssh key in their configuration that was then not working in the authentication. A fallback to the default ssh key still allowed the tests to pass. Because of these fallbacks several tests had to be adapted.I am must say in hindsight this is not super useful, but I like that the tests do actually use the ssh key that is specified as this is nowhere mentioned and a bit confusing when adapting these parts of the code.
Requires #6450 to be merged before.