CLI: Add verdi devel launch-multiply-add
#6601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agoscinski
reviewed
Nov 4, 2024
| assert re.search(r'Submitted workflow', result.stdout) | ||
|
|
||
| node = QueryBuilder().append(ProcessNode, tag='node').order_by({'node': {'ctime': 'desc'}}).first(flat=True) | ||
| submit_and_await(node) |
There was a problem hiding this comment.
very useful command, did not know about it
There was a problem hiding this comment.
Literally copy-pasted everything from the tests for verdi devel launch-add :D but yes, indeed very useful, thanks for pointing it out!
| configures ``bash`` on the ``localhost``. If the localhost is not yet configured as a ``Computer``, that is also | ||
| done automatically. | ||
| """ | ||
| from shutil import which |
There was a problem hiding this comment.
did not know about it, useful
Story of my life :D |
GeigerJ2
force-pushed
the
feature/devel-launch-multiply-add
branch
from
ee41c82
to
7d4fe57
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6601 +/- ##
==========================================
+ Coverage 77.51% 77.89% +0.39%
==========================================
Files 560 567 +7
Lines 41444 42151 +707
==========================================
+ Hits 32120 32829 +709
+ Misses 9324 9322 -2 ☔ View full report in Codecov by Sentry. |
Without it, the `localhost` computer would have already been created in the tests for `launch-add`, so the first test for `launch-multiply-add` would fail.
GeigerJ2
force-pushed
the
feature/devel-launch-multiply-add
branch
from
7d4fe57
to
bd7e99e
Compare
|
Pls approve when CI is done, @agoscinski, pretty please :3 |
agoscinski
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For us
devs(@agoscinski, @khsrali) to also debug WorkChains, and/or get those into a fresh profile, akin toverdi devel launch-add.