Skip to content

Fix collection and query iterable issue #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Some1Somewhere wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix collection and query iterable issue #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5774552
returning a list so it matches firestore
Some1Somewhere Jun 13, 2025
0f76d69
Update collection.py
Some1Somewhere Jun 26, 2025
3b8a509
update comments
Some1Somewhere Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions mockfirestore/collection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,8 @@ def document(self, document_id: Optional[str] = None) -> DocumentReference:
return DocumentReference(self._data, new_path, parent=self)

def get(self) -> Iterable[DocumentSnapshot]:
warnings.warn('Collection.get is deprecated, please use Collection.stream',
category=DeprecationWarning)
return self.stream()
# Stream uses a generator, so we need to convert it to a list for compatibility for .get() method with firestore library
return list(self.stream())

@property
def path(self):
Expand Down Expand Up @@ -127,9 +126,8 @@ def document(self, document_id: Optional[str] = None, path: List[str] = None) ->
return ret

def get(self) -> Iterable[DocumentSnapshot]:
warnings.warn('Collection.get is deprecated, please use Collection.stream',
category=DeprecationWarning)
return self.stream()
# Stream uses a generator, so we need to convert it to a list for compatibility for .get() method with firestore library
return list(self.stream())

def stream(self, transaction=None) -> Iterable[DocumentSnapshot]:
for path in self._path:
Expand Down
7 changes: 3 additions & 4 deletions mockfirestore/query.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,11 @@ def stream(self, transaction=None) -> Iterator[DocumentSnapshot]:
if self._limit:
doc_snapshots = islice(doc_snapshots, self._limit)

return iter(doc_snapshots)
return iter(list(doc_snapshots))

def get(self) -> Iterator[DocumentSnapshot]:
warnings.warn('Query.get is deprecated, please use Query.stream',
category=DeprecationWarning)
return self.stream()
# Stream uses a generator, so we need to convert it to a list for compatibility for .get() method with firestore library
return list(self.stream())

def _add_field_filter(self, field: str, op: str, value: Any):
compare = self._compare_func(op)
Expand Down