-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce skip_cache_func #652
Introduce skip_cache_func #652
Conversation
Unit tests for that functionality is not done yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
A couple of suggestions there, and we'll also need some tests for the new behaviour (maybe in tests/acceptance/tests_decorator.py so it gets tested against the different backends).
Ignore the news fragment. I'm not sure where that checklist comes from, trying to see if I can edit it... |
Updated the code, please check |
Codecov Report
@@ Coverage Diff @@
## master #652 +/- ##
=======================================
Coverage 99.67% 99.67%
=======================================
Files 35 35
Lines 3707 3743 +36
=======================================
+ Hits 3695 3731 +36
Misses 12 12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
OK, looking good. If we can just get a couple of tests in (maybe in tests/acceptance/tests_decorator.py?), then we're good to merge. |
Done with tests |
Added cached_stampede to the tests to get full coverage, all good now. Thanks a lot for that. |
Co-authored-by: Vitaly Petrov <[email protected]> Co-authored-by: Sam Bull <[email protected]>
value_checker
param to cache decorator classescached
,cached_stampede
andmulti_cached
gitignore
Are there changes in behavior for the user?
Did not test in real production code
Related issue number
Fixes #649
Checklist
CHANGES
folder