Add a PXD only Cython extension for the WebSocket reader to improve p…

…erformance (#9543)

CHANGES/9543.feature.rst

@@ -0,0 +1 @@
+Improved performance of reading WebSocket messages with a Cython implementation -- by :user:`bdraco`.

Makefile

@@ -56,6 +56,11 @@ endif
 aiohttp/_find_header.c: $(call to-hash,aiohttp/hdrs.py ./tools/gen.py)
 	./tools/gen.py
 
+# Special case for reader since we want to be able to disable
+# the extension with AIOHTTP_NO_EXTENSIONS
+aiohttp/_websocket/reader_c.c: aiohttp/_websocket/reader_c.py
+	cython -3 -o $@ $< -I aiohttp -Werror
+
 # _find_headers generator creates _headers.pyi as well
 aiohttp/%.c: aiohttp/%.pyx $(call to-hash,$(CYS)) aiohttp/_find_header.c
 	cython -3 -o $@ $< -I aiohttp -Werror
@@ -74,7 +79,7 @@ vendor/llhttp/node_modules: vendor/llhttp/package.json
 generate-llhttp: .llhttp-gen
 
 .PHONY: cythonize
-cythonize: .install-cython $(PYXS:.pyx=.c)
+cythonize: .install-cython $(PYXS:.pyx=.c) aiohttp/_websocket/reader_c.c
 
 .install-deps: .install-cython $(PYXS:.pyx=.c) $(call to-hash,$(CYS) $(REQS))
 	@python -m pip install -r requirements/dev.in -c requirements/dev.txt
@@ -157,6 +162,7 @@ clean:
 	@rm -f aiohttp/_http_parser.c
 	@rm -f aiohttp/_http_writer.c
 	@rm -f aiohttp/_websocket.c
+	@rm -f aiohttp/_websocket/reader_c.c
 	@rm -rf .tox
 	@rm -f .develop
 	@rm -f .flake

aiohttp/_websocket/mask.pxd

@@ -0,0 +1,3 @@
+"""Cython declarations for websocket masking."""
+
+cpdef void _websocket_mask_cython(bytes mask, bytearray data)

aiohttp/_websocket/mask.pyx

@@ -8,7 +8,7 @@ cdef extern from "Python.h":
 from libc.stdint cimport uint32_t, uint64_t, uintmax_t
 
 
-def _websocket_mask_cython(object mask, object data):
+cpdef void _websocket_mask_cython(bytes mask, bytearray data):
     """Note, this function mutates its `data` argument
     """
     cdef:
@@ -21,14 +21,6 @@ def _websocket_mask_cython(object mask, object data):
 
     assert len(mask) == 4
 
-    if not isinstance(mask, bytes):
-        mask = bytes(mask)
-
-    if isinstance(data, bytearray):
-        data = <bytearray>data
-    else:
-        data = bytearray(data)
-
     data_len = len(data)
     in_buf = <unsigned char*>PyByteArray_AsString(data)
     mask_buf = <const unsigned char*>PyBytes_AsString(mask)