Allow checking whether Duration is zero length #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electrum
approved these changes
Apr 11, 2023
| @@ -164,6 +169,11 @@ public int compareTo(Duration o) | |||
| return Double.compare(getValue(MILLISECONDS), o.getValue(MILLISECONDS)); | |||
| } | |||
|
|
|||
| public boolean isZero() | |||
| { | |||
| return compareTo(ZERO) == 0; | |||
There was a problem hiding this comment.
Why not
return equals(ZERO);This gets us the fast identity comparison, which seems to be the point of having a ZERO constant instance.
findepi
force-pushed
the
findepi/allow-checking-whether-duration-is-zero-length-b0d267
branch
2 times, most recently
from
87935e7
to
a8d741e
Compare
|
PTAL |
This introduces new API method for checking whether duration is empty. The tempting terse alternative of `duration.toMillis() == 0` does not work correctly for sub-milli duration, so it's better to provide a shortcut that's correct.
findepi
force-pushed
the
findepi/allow-checking-whether-duration-is-zero-length-b0d267
branch
from
a8d741e
to
8cb2838
Compare
|
New code extracted to #33, PTAL there. |
findepi
deleted the
findepi/allow-checking-whether-duration-is-zero-length-b0d267
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces new API method for checking whether duration is empty.
The tempting terse alternative of
duration.toMillis() == 0does notwork correctly for sub-milli duration, so it's better to provide a
shortcut that's correct.