-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate units validation to jakarta #32
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electrum
reviewed
Jun 28, 2023
wendigo
force-pushed
the
serafin/jakarta-unit
branch
2 times, most recently
from
July 4, 2023 09:59
3eae163
to
11c3b83
Compare
findepi
reviewed
Jul 4, 2023
findepi
reviewed
Jul 4, 2023
Airlift and Trino are using JDK 17 as a minimum required version, which makes testing on 11 no longer needed.
wendigo
force-pushed
the
serafin/jakarta-unit
branch
from
July 4, 2023 10:17
11c3b83
to
23f1c21
Compare
findepi
reviewed
Jul 4, 2023
findepi
reviewed
Jul 4, 2023
findepi
reviewed
Jul 4, 2023
wendigo
force-pushed
the
serafin/jakarta-unit
branch
2 times, most recently
from
July 4, 2023 12:49
8ca2a0b
to
0dc716b
Compare
findepi
reviewed
Jul 4, 2023
wendigo
force-pushed
the
serafin/jakarta-unit
branch
from
July 4, 2023 12:55
0dc716b
to
028a3bf
Compare
findepi
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @electrum
needed for trinodb/trino#18047