Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic devcontainers.json Verify #44

Merged
merged 33 commits into from
Dec 26, 2022
Merged

Automatic devcontainers.json Verify #44

merged 33 commits into from
Dec 26, 2022

Conversation

airscripts
Copy link
Owner

Pull Request

Compile all the information written below to send a legitimate pull request to the repository!

Label:

This PR is labeled as:

Choose only one and remember to select the label even on the right.

  • Feature

Linked Issue

This PR has the following linked issues:

Solution

My solution is explained as follows:

I've created a new pre-commit hook that checks for changes on devcontainer files.
If a change is detected, an automatic verify is run in a containerized environment using devcontainers CLI.

@airscripts airscripts added the feature New feature label Dec 26, 2022
@airscripts airscripts self-assigned this Dec 26, 2022
@airscripts
change(docker): change devcontainer environment dockerfile workdir fr…
5de41d8 
…om home to tmp
@airscripts
change(scripts): change devcontainer environment config path in verif…
1dfea42 
…y script
@airscripts
refactor(devcontainers): group devcontainer files into template folders
7a968a0
@airscripts
fix(docker): switch from tmp to home default folder in environment do…
14fe45c 
…ckerfile
@airscripts
refactor(githooks): switch plain command with make rule invocation
dbdd70c
@airscripts
fix(scripts): fix incorrect path into environment verify script
ba50ae2
@airscripts
feat(makefile): add devcontainers rules
83f526b
@airscripts
revert(devcontainers): rollback folder structure to mono config file
cf50d72
@airscripts
change(devcontainer): rename base image
e7299f0
@airscripts
refactor(docker): rename environment dockerfile to devcontainer docke…
79028a9 
…rfile
@airscripts
refactor(scripts): rename environment folder to devcontainer
3ab5e92
@airscripts
fix(githooks): change wrong rule for devcontainer
648237c
@airscripts
refactor(makefile): fine tuning on devcontainer rules
4676a81
@airscripts
feat(docker): add entrypoint file for devcontainer dockerfile
6a55dcc
@airscripts
docs: update README file
a9d3641
@airscripts airscripts marked this pull request as ready for review December 26, 2022 17:33
@airscripts airscripts merged commit 8c396ec into main Dec 26, 2022
@airscripts airscripts deleted the feat-devcontainers-automation-ff51 branch December 26, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@airscripts airscripts

Labels
feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automatic devcontainer.json Verify
1 participant
@airscripts