Skip to content

Fix TODO workflow#476

Merged
ajwheeler merged 1 commit intomainfrom
fix-TODO
Aug 8, 2025
Merged

Fix TODO workflow#476
ajwheeler merged 1 commit intomainfrom
fix-TODO

Conversation

@ajwheeler
Copy link
Owner

My TODO workflow has recently started failing, see e.g. #450.

@ajwheeler
Copy link
Owner Author

This seems to have fixed it.

@ajwheeler ajwheeler merged commit f9a8b61 into main Aug 8, 2025
9 of 10 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2025

Benchmark Results (Julia v1)

Time benchmarks
main 574b1b1... main / 574b1b1...
synthesis/M dwarf/100 Å of APOGEE w/ water 7.62 ± 0.0075 s 7.41 ± 0.054 s 1.03 ± 0.0075
synthesis/M dwarf/4000 Å - 8000 Å VALD solar 12.5 ± 0.037 s 12.5 ± 0.0034 s 1.01 ± 0.003
synthesis/M dwarf/APOGEE DR17 w/o water 9.51 ± 0.015 s 9.4 ± 0.0064 s 1.01 ± 0.0018
synthesis/M dwarf/one wavelength 0.367 ± 0.0006 s 0.307 ± 0.00056 s 1.19 ± 0.0029
synthesis/sun/100 Å of APOGEE w/ water 0.87 ± 0.0011 s 0.851 ± 0.0016 s 1.02 ± 0.0023
synthesis/sun/4000 Å - 8000 Å VALD solar 5.6 ± 0.016 s 5.59 ± 0.016 s 1 ± 0.0041
synthesis/sun/APOGEE DR17 w/o water 4.94 ± 0.011 s 4.86 ± 0.059 s 1.02 ± 0.013
synthesis/sun/one wavelength 0.135 ± 0.0004 s 0.118 ± 0.00042 s 1.14 ± 0.0053
time_to_load 2.71 ± 0.02 s 2.72 ± 0.018 s 0.996 ± 0.0098
Memory benchmarks
main 574b1b1... main / 574b1b1...
synthesis/M dwarf/100 Å of APOGEE w/ water 1.73 M allocs: 3.21 GB 1.73 M allocs: 3.21 GB 1
synthesis/M dwarf/4000 Å - 8000 Å VALD solar 8.62 M allocs: 7.11 GB 8.62 M allocs: 7.11 GB 1
synthesis/M dwarf/APOGEE DR17 w/o water 5.6 M allocs: 5.11 GB 5.6 M allocs: 5.11 GB 1
synthesis/M dwarf/one wavelength 1.15 M allocs: 0.288 GB 1.15 M allocs: 0.288 GB 1
synthesis/sun/100 Å of APOGEE w/ water 1.17 M allocs: 0.226 GB 1.17 M allocs: 0.226 GB 1
synthesis/sun/4000 Å - 8000 Å VALD solar 8.48 M allocs: 2.81 GB 8.48 M allocs: 2.81 GB 1
synthesis/sun/APOGEE DR17 w/o water 5.29 M allocs: 2.12 GB 5.29 M allocs: 2.12 GB 1
synthesis/sun/one wavelength 0.782 M allocs: 0.107 GB 0.782 M allocs: 0.107 GB 1
time_to_load 0.159 k allocs: 11.2 kB 0.159 k allocs: 11.2 kB 1

@ajwheeler ajwheeler deleted the fix-TODO branch September 4, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant