Add ClusterIssuer to hostname-operator #196
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
suggested changes
Feb 22, 2023
cloud-j-luna
requested review from
a user and
boz
and removed request for
a user
ghost
self-requested a review
ghost
reviewed
Feb 23, 2023
ghost
suggested changes
Feb 23, 2023
There was a problem hiding this comment.
Will merge it once akash-network/provider#86 is merged.
Update (June 14 2023): PR #86 has been replaced by akash-network/provider#112 WIP
boz
reviewed
Feb 27, 2023
Contributor
boz
left a comment
boz
left a comment
There was a problem hiding this comment.
lgtm but I defer to @andy108369
Member
Author
|
This can be closed as it's extremely outdated, no? @andy108369 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the support for ClusterIssuer and Issuer as well as setting the environment variables on the
akash-hostname-operator.