-
Notifications
You must be signed in to change notification settings - Fork 244
feat: sdk-50 #1998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: sdk-50 #1998
Changes from all commits
e2c7e34
3963470
295fd97
11a79a7
815b25f
0d2d6e4
318aea4
c5a26c4
4c7bfce
5c38995
85c1e8a
fa11f6f
f4d8bb0
b66bf49
4879a09
2196bcc
1e1a093
14110ca
5cf47bf
0962b8f
c81cab8
734b5b3
c7e5f00
359e5e1
2aa9091
291ff5d
595df1b
90e8fdc
353da27
3b48240
ac05cb5
0d3edd3
ff4aa82
a8c65a8
65d0a37
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
github.com/akash-network/node |
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,29 @@ | ||||||||||||||||||||||||
--- | ||||||||||||||||||||||||
name: setup-ubuntu | ||||||||||||||||||||||||
runs: | ||||||||||||||||||||||||
using: 'composite' | ||||||||||||||||||||||||
steps: | ||||||||||||||||||||||||
- name: Fetch all tags | ||||||||||||||||||||||||
shell: bash | ||||||||||||||||||||||||
run: git fetch --prune --unshallow | ||||||||||||||||||||||||
Comment on lines
+6
to
+8
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Make git fetch robust for both shallow and full clones.
Apply this diff: - - name: Fetch all tags
- shell: bash
- run: git fetch --prune --unshallow
+ - name: Fetch all tags
+ shell: bash
+ run: |
+ if git rev-parse --is-shallow-repository >/dev/null 2>&1; then
+ git fetch --prune --unshallow --tags
+ else
+ git fetch --prune --tags
+ fi 📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents
|
||||||||||||||||||||||||
- name: Install dependencies | ||||||||||||||||||||||||
# Shell must explicitly specify the shell for each step. https://github.com/orgs/community/discussions/18597 | ||||||||||||||||||||||||
shell: bash | ||||||||||||||||||||||||
run: sudo apt install -y make direnv unzip lz4 wget curl npm jq pv coreutils | ||||||||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Run apt-get update and avoid installing npm via apt to prevent conflicts with setup-node.
Apply this diff: - run: sudo apt install -y make direnv unzip lz4 wget curl npm jq pv coreutils
+ run: |
+ sudo apt-get update -y
+ sudo apt-get install -y make direnv unzip lz4 wget curl jq pv coreutils
🤖 Prompt for AI Agents
|
||||||||||||||||||||||||
- name: Setup npm | ||||||||||||||||||||||||
uses: actions/setup-node@v4 | ||||||||||||||||||||||||
with: | ||||||||||||||||||||||||
node-version: 18 | ||||||||||||||||||||||||
- name: Detect required Go version | ||||||||||||||||||||||||
shell: bash | ||||||||||||||||||||||||
run: | | ||||||||||||||||||||||||
toolchain=$(./script/tools.sh gotoolchain | sed 's/go*//') | ||||||||||||||||||||||||
echo "GOVERSION=${toolchain}" >> $GITHUB_ENV | ||||||||||||||||||||||||
Comment on lines
+20
to
+21
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Fix sed expression and quote variables when exporting GOVERSION.
Apply this diff: - toolchain=$(./script/tools.sh gotoolchain | sed 's/go*//')
- echo "GOVERSION=${toolchain}" >> $GITHUB_ENV
+ toolchain="$(./script/tools.sh gotoolchain | sed -E 's/^go//')"
+ echo "GOVERSION=${toolchain}" >> "$GITHUB_ENV" 📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents
|
||||||||||||||||||||||||
- uses: actions/setup-go@v5 | ||||||||||||||||||||||||
with: | ||||||||||||||||||||||||
go-version: "${{ env.GOVERSION }}" | ||||||||||||||||||||||||
check-latest: true | ||||||||||||||||||||||||
- name: set environment | ||||||||||||||||||||||||
uses: HatsuneMiku3939/direnv-action@v1 | ||||||||||||||||||||||||
with: | ||||||||||||||||||||||||
masks: '' |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,17 +12,10 @@ jobs: | |
publish: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- run: git fetch --prune --unshallow | ||
- name: Detect required Go version | ||
run: | | ||
toolchain=$(./script/tools.sh gotoolchain | sed 's/go*//') | ||
echo "GOVERSION=${toolchain}" >> $GITHUB_ENV | ||
- uses: actions/setup-go@v5 | ||
with: | ||
go-version: "${{ env.GOVERSION }}" | ||
- name: set environment | ||
uses: HatsuneMiku3939/direnv-action@v1 | ||
- name: Checkout code | ||
uses: actions/checkout@v4 | ||
- name: Setup environment | ||
uses: ./.github/actions/setup-ubuntu | ||
- name: Set up QEMU | ||
uses: docker/setup-qemu-action@v3 | ||
- name: Set up Docker Buildx | ||
|
@@ -45,21 +38,18 @@ jobs: | |
# using PAT as homebrew is located in different repo | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
test-network-upgrade-on-release: | ||
runs-on: upgrade-tester | ||
runs-on: gh-runner-test | ||
needs: | ||
Comment on lines
+41
to
42
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unknown runner label
🧰 Tools🪛 actionlint (1.7.7)41-41: label "gh-runner-test" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file (runner-label) 🤖 Prompt for AI Agents
|
||
- publish | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- run: git fetch --prune --unshallow | ||
- name: Detect required Go version | ||
- name: Cleanup build folder | ||
run: | | ||
toolchain=$(./script/tools.sh gotoolchain | sed 's/go*//') | ||
echo "GOVERSION=${toolchain}" >> $GITHUB_ENV | ||
- uses: actions/setup-go@v5 | ||
with: | ||
go-version: "${{ env.GOVERSION }}" | ||
- name: set environment | ||
uses: HatsuneMiku3939/direnv-action@v1 | ||
sudo rm -rf ./* || true | ||
sudo rm -rf ./.??* || true | ||
- name: Checkout code | ||
uses: actions/checkout@v4 | ||
- name: Setup environment | ||
uses: ./.github/actions/setup-ubuntu | ||
- name: detect release tag | ||
run: echo "RELEASE_TAG=${GITHUB_REF#refs/tags/}" >> $GITHUB_ENV | ||
- name: configure variables | ||
|
@@ -71,6 +61,7 @@ jobs: | |
env: | ||
UPGRADE_BINARY_VERSION: ${{ env.RELEASE_TAG }} | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
TEST_CONFIG: test-config-gha.json | ||
run: | | ||
cd tests/upgrade | ||
make test | ||
|
@@ -80,7 +71,7 @@ jobs: | |
with: | ||
name: logs | ||
path: | | ||
.cache/run/upgrade/validators/logs/*.log | ||
.cache/run/upgrade/validators/logs/.akash*.log | ||
|
||
notify-homebrew: | ||
runs-on: ubuntu-latest | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Guard GOPATH discovery with a go availability check.
go env GOPATH
will fail if Go isn’t installed in a fresh local environment.Apply this diff:
📝 Committable suggestion
🤖 Prompt for AI Agents