Skip to content

fix: use of requestStreamParams middleware in streaming routes #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use of requestStreamParams middleware in streaming routes #302

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions gateway/rest/router.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,19 +172,16 @@ func newRouter(log log.Logger, addr sdk.Address, pclient provider.Client, ctxCon
leaseStatusHandler(log, pclient.Cluster(), ctxConfig)).
Methods(http.MethodGet)

streamRouter := lrouter.NewRoute().Subrouter()
streamRouter.Use(requestStreamParams)

mrouter = streamRouter.NewRoute().Subrouter()
mrouter.Use(requireEndpointScopeForLeaseID(ajwt.PermissionScopeEvents))
mrouter = lrouter.NewRoute().Subrouter()
mrouter.Use(requestStreamParams, requireEndpointScopeForLeaseID(ajwt.PermissionScopeEvents))

// GET /lease/<lease-id>/kubeevents
mrouter.HandleFunc("/kubeevents",
leaseKubeEventsHandler(log, pclient.Cluster())).
Methods("GET")

mrouter = lrouter.NewRoute().Subrouter()
mrouter.Use(requireEndpointScopeForLeaseID(ajwt.PermissionScopeLogs))
mrouter.Use(requestStreamParams, requireEndpointScopeForLeaseID(ajwt.PermissionScopeLogs))

// GET /lease/<lease-id>/logs
mrouter.HandleFunc("/logs",
Expand Down