update to 6.0 #545
update to 6.0 #545
Conversation
| using Akka.Persistence.Sql.Db; | ||
| using Akka.Persistence.Sql.Journal.Types; | ||
| using LinqToDB; | ||
| using LinqToDB.Async; |
There was a problem hiding this comment.
Things got moved, now this namespace is a thing for ToListAsync/ToDictionaryAsync etc.
| ProviderType.MySqlOfficial => ProviderName.MySql80MySqlData,//.MySqlOfficial, | ||
| ProviderType.MySqlConnector => ProviderName.MySql80MySqlConnector, |
There was a problem hiding this comment.
Should we add ProviderType changes here for the Tag Table migration Big difference is things are now a bit more explicit for MySQL versions...
Not sure if this implies config updates required (We could always try to translate if needed I guess?
| public override string ConnectionString => _connectionStringBuilder.ToString(); | ||
|
|
||
| public override string ProviderName => LinqToDB.ProviderName.MySqlOfficial; | ||
| public override string ProviderName => LinqToDB.ProviderName.MySql80MySqlConnector;//.MySqlOfficial; |
There was a problem hiding this comment.
Possibly should actually be MySql80MySqlData ?
|
|
||
| public AkkaDataConnection Clone() | ||
| => new(_providerName, (DataConnection)_connection.Clone()); | ||
| => throw new NotSupportedException();//_providerName, (DataConnection)_connection.Clone()); |
There was a problem hiding this comment.
We have twothree options here...
Option 1 - Take what I did here and treat it as Not Supported.
Option 2 - Have AkkaDataConnection take in the actual connection string as well, and then just have Clone() use that
Option 3 - Just get rid of this method; -should- be a compile time break (bad) but should show up right away in most sane CI setups.
(If we go with 1 or 2, we'll still need to mark this as obsolete via attr)
1 participant
Fixes #
Changes
Please provide a brief description of the changes here.
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):
Latest
devBenchmarksInclude data from the relevant benchmark prior to this change here.
This PR's Benchmarks
Include data from after this change here.