Streampay guided steps #86
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfallows
requested changes
Jun 20, 2024
...main/java/io/aklivity/zilla/demo/streampay/stream/processor/ProcessValidCommandSupplier.java
Outdated
Show resolved
Hide resolved
Comment on lines
18
to
20
| private String requestId; | ||
| private double amount; | ||
| private String notes; | ||
| private String requestId; |
There was a problem hiding this comment.
Can this change be reverted?
streampay/avro/commands.avro
Outdated
| { | ||
| "type": "record", | ||
| "name": "PaymentCommand", | ||
| "namespace": "com.example", |
There was a problem hiding this comment.
Suggested change
| "namespace": "com.example", | |
| "namespace": "io.aklivity.demos.streampay", |
streampay/avro/replies.avro
Outdated
| { | ||
| "type": "record", | ||
| "name": "Replies", | ||
| "namespace": "com.example", |
There was a problem hiding this comment.
Suggested change
| "namespace": "com.example", | |
| "namespace": "io.aklivity.demos.streampay", |
streampay/avro/user-balance.avro
Outdated
| { | ||
| "type": "record", | ||
| "name": "UserBalance", | ||
| "namespace": "com.example", |
There was a problem hiding this comment.
Suggested change
| "namespace": "com.example", | |
| "namespace": "io.aklivity.demos.streampay", |
Comment on lines
5
to
17
| servers: | ||
| cluster: | ||
| host: 'pkc-41p56.asia-south1.gcp.confluent.cloud:443' | ||
| protocol: kafka | ||
| description: Confluent Kafka instance. | ||
| security: | ||
| - $ref: '#/components/securitySchemes/confluentBroker' | ||
| schema-registry: | ||
| host: psrc-e8157.us-east-2.aws.confluent.cloud | ||
| protocol: kafka | ||
| description: Confluent Kafka Schema Registry Server | ||
| security: | ||
| - $ref: '#/components/securitySchemes/confluentSchemaRegistry' |
There was a problem hiding this comment.
We can probably remove this servers section from the generated spec and inject the server information when we "deploy" the spec instead, agree?
Comment on lines
354
to
365
| securitySchemes: | ||
| confluentBroker: | ||
| type: userPassword | ||
| x-configs: | ||
| sasl.mechanisms: PLAIN | ||
| sasl.password: '{{CLUSTER_API_SECRET}}' | ||
| sasl.username: '{{CLUSTER_API_KEY}}' | ||
| security.protocol: sasl_ssl | ||
| confluentSchemaRegistry: | ||
| type: userPassword | ||
| x-configs: | ||
| basic.auth.user.info: '{{SCHEMA_REGISTRY_API_KEY}}:{{SCHEMA_REGISTRY_API_SECRET}}' |
There was a problem hiding this comment.
We can defer securitySchemes until "deploy" similar to servers section above.
streampay/stack/conf/zilla.yaml
Outdated
| vaults: | ||
| filesystem2814ec86-7736-49c9-babe-d8e6cedde0dc: | ||
| --- | ||
| name: zilla-mqtt-kafka-broker |
There was a problem hiding this comment.
Suggested change
| name: zilla-mqtt-kafka-broker | |
| name: zilla-demos-streampay |
streampay/stream.sql
Outdated
| -- PARTITIONS=2, | ||
| -- VALUE_FORMAT=avro | ||
| -- ); | ||
|
|
There was a problem hiding this comment.
CREATE TOPIC for other required Kafka topics.
streampay/stream.sql
Outdated
|
|
||
|
|
||
| CREATE MATERIALIZED VIEW IF NOT EXISTS invalid_commands AS | ||
| SELECT bad_request_status() as status, correlationid::varchar as correlationid from commands where key IS NULL OR type NOT IN ('PayCommand', 'RequestCommand'); |
There was a problem hiding this comment.
Let's change the types to SendPaymentCommand and RequestPaymentCommand, or just SendPayment and RequestPayment if the context of "command" is implicit.
|
This one is no longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.