Develop #768
Open
Develop #768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack89roberts
force-pushed
the
develop
branch
from
cecd057 to
1e0657a
Compare
jack89roberts
force-pushed
the
develop
branch
from
fa9cdaf to
c44196e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #768 +/- ##
==========================================
- Coverage 62.32% 61.92% -0.41%
==========================================
Files 32 32
Lines 4263 4299 +36
==========================================
+ Hits 2657 2662 +5
- Misses 1606 1637 +31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@lolzeclegend This should fix your issues |
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the optimization system to track points hits per gameweek in addition to total points hits across the optimization window. The version is bumped from 1.14.2 to 1.14.3.
- Modified the return signature of
next_week_transfers()to include both total points hits and points hits for the current gameweek - Updated the optimization flow to track and display per-gameweek points hits
- Fixed the calculation of free transfers available from the API to account for transfers already made
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Version bump from 1.14.2 to 1.14.3 |
| airsenal/framework/optimization_utils.py | Modified next_week_transfers() to return 4-tuple with hit_this_gw; changed zip strict parameter to True |
| airsenal/scripts/fill_transfersuggestion_table.py | Updated to handle 4-tuple from next_week_transfers(); added Points Hits display; threaded use_api parameter |
| airsenal/tests/test_optimization.py | Updated all test assertions to expect 4-tuples; added new test cases for edge scenarios |
| airsenal/framework/data_fetcher.py | Fixed free transfers calculation to subtract transfers already made |
Comments suppressed due to low confidence (1)
airsenal/framework/optimization_utils.py:1
- [nitpick] The label 'Points Hits' should use singular form 'Points Hit' for grammatical consistency, as it refers to the point penalty amount.
"""
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Bumps [matplotlib](https://github.com/matplotlib/matplotlib) from 3.10.6 to 3.10.7. - [Release notes](https://github.com/matplotlib/matplotlib/releases) - [Commits](matplotlib/matplotlib@v3.10.6...v3.10.7) --- updated-dependencies: - dependency-name: matplotlib dependency-version: 3.10.7 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [jupyterlab](https://github.com/jupyterlab/jupyterlab) from 4.4.9 to 4.4.10. - [Release notes](https://github.com/jupyterlab/jupyterlab/releases) - [Changelog](https://github.com/jupyterlab/jupyterlab/blob/main/RELEASE.md) - [Commits](https://github.com/jupyterlab/jupyterlab/compare/@jupyterlab/[email protected]...@jupyterlab/[email protected]) --- updated-dependencies: - dependency-name: jupyterlab dependency-version: 4.4.10 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [types-python-dateutil](https://github.com/typeshed-internal/stub_uploader) from 2.9.0.20250822 to 2.9.0.20251008. - [Commits](https://github.com/typeshed-internal/stub_uploader/commits) --- updated-dependencies: - dependency-name: types-python-dateutil dependency-version: 2.9.0.20251008 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [platformdirs](https://github.com/tox-dev/platformdirs) from 4.4.0 to 4.5.0. - [Release notes](https://github.com/tox-dev/platformdirs/releases) - [Changelog](https://github.com/tox-dev/platformdirs/blob/main/CHANGES.rst) - [Commits](tox-dev/platformdirs@4.4.0...4.5.0) --- updated-dependencies: - dependency-name: platformdirs dependency-version: 4.5.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [sqlalchemy](https://github.com/sqlalchemy/sqlalchemy) from 2.0.43 to 2.0.44. - [Release notes](https://github.com/sqlalchemy/sqlalchemy/releases) - [Changelog](https://github.com/sqlalchemy/sqlalchemy/blob/main/CHANGES.rst) - [Commits](https://github.com/sqlalchemy/sqlalchemy/commits) --- updated-dependencies: - dependency-name: sqlalchemy dependency-version: 2.0.44 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for teams entered after GW1 and running AIrsenal when transfers have already been made in a GW.
Closes #736
Closes #765
Closes #767