Merged
Conversation
Pass simulator output_names (or configured channel_names) through the CLI visualization pipeline and use them for channel titles. Add a preserve_aspect option to control imshow aspect ratio. Set explicit default output_names for several simulators and adjust ShallowWater defaults (dt_save, amp) since beyond ~0.15 there are issues with numerical stability. Add tests for output names and visualization.
Adjust time discretization and viscosity for shorter
Add new ReactionDiffusion implementation under autosim.experimental.simulations Update config to reference the new path and remove the simulator from the top-level simulations package
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3.
This PR:
SpatioTemporalSimulator