Packaging for composer / packagist #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why use composer instead of just one class file? I really don't see how this would be useful. It's only one simple file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @albeebe, nice work on this project!
I hope you'll consider this PR which enables your library to be used through composer and be submitted to packagist.org. This way other projects can more easily use your code in their projects.
Changes:
composer.jsonclass.findmyiphone.phpintosrc/withFindMyiPhoneas their namespaceexample.phpandREADME.mdto incorporate the previous changes..editorconfigfile to follow the current white-space conventions (tabs vs spaces).gitignoreto play nice with composerI've tested and can confirm that the example works as before.
If you choose to accept this PR, please go to packagist.org and submit this package. This way other projects can pull in this code through composer.
Let me know if there's any suggestions or questions!
Joost