feat: enhance pathfinding options with maxCost, maxNodes, and allowedCallback#47
Open
123FLO321 wants to merge 9 commits intoalbertorestifo:masterfrom
Open
feat: enhance pathfinding options with maxCost, maxNodes, and allowedCallback#47123FLO321 wants to merge 9 commits intoalbertorestifo:masterfrom
123FLO321 wants to merge 9 commits intoalbertorestifo:masterfrom
Conversation
123FLO321
changed the title
Owner
albertorestifo
left a comment
albertorestifo
left a comment
There was a problem hiding this comment.
Thanks for your contribution! :)
Left a couple of notes, let me know what you think.
Owner
|
Ah also I see there are some errors from Prettier, can you please run it on the code? Thanks! |
Author
|
@albertorestifo I fixed the lint issues (and also moved lint from the test script and explicitly run it in the workflow). |
123FLO321
commented
Nov 6, 2025
|
|
||
| // Add the starting point to the frontier, it will be the first node visited | ||
| frontier.set(start, 0); | ||
| depth.set(start, 1); |
Author
There was a problem hiding this comment.
Should depth start at 0 or 1 for the root node?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds new constraints and customization options to the
Graphclass'spath()method, enhancing its flexibility for pathfinding. It introduces support for limiting the maximum cost and maximum number of nodes in a path, as well as a callback to control which edges are allowed during path expansion.Tests for new cases are added.
closes #46
Also includes types (from @types/node-dijkstra) with modifications untill #45 is merged.