This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
add hardcoded HTML for styling cat life events #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A first step on #1 - add cat life event tracker for visualizing reducers. This adds just the hardcoded HTML for a cat life event tracker. It's not fully wired up, and not fully data driven. This allows us to do some styling but also use a little less imagination to see the cat life event tracker coming together.
LoganBarnett
commented
Nov 28, 2022
| <tr> | ||
| <td>2022.11.27</td> | ||
| <td>lost a life</td> | ||
| <td>Acylsm</td> |
There was a problem hiding this comment.
Where does this name come from?
There was a problem hiding this comment.
const foo = bar()Change foo to bar.
This is a better cat name:
Suggested change
| <td>Acylsm</td> | |
| <td>Garfield</td> |
There was a problem hiding this comment.
Before merging:
- Clean up typos
- Explain how cat names appeared
LoganBarnett
commented
Nov 28, 2022
| <tr> | ||
| <td>2022.11.25</td> | ||
| <td>made friends with a dog</td> | ||
| <td>Spaw</td> |
There was a problem hiding this comment.
Oh I get it: "Catspaw"!
LoganBarnett
commented
Nov 28, 2022
| return <> | ||
| {props.children} | ||
| </> | ||
| return <div> |
There was a problem hiding this comment.
div works for a lot of things, but I think there's a more semantic tag for this. Have you looked into section?
Here's MDN's docs on it: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/section
Specifically I'm looking at this:
The
HTML element represents a generic standalone section of a document, which doesn't have a more specific semantic element to represent it.
Suggested change
| return <div> | |
| return <section> |
But also you'll need to cover the end tag if you apply this change.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A first step on #1 - add cat life event tracker for visualizing reducers.
This adds just the hardcoded HTML for a cat life event tracker. It's not fully wired up, and not fully data driven. This allows us to do some styling but also use a little less imagination to see the cat life event tracker coming together.