qibuild: generating the project.cmake file #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating the project.cmake file containing the project version number when running qibuild configure. This file allows the use of the qiproject.xml information in CMake. It is automatically included by the qibuild-config.cmake in the same way than the dependencies.cmake.
dmerejkowsky
reviewed
Oct 9, 2017
python/qibuild/project.py
Outdated
| ############################################# | ||
|
|
||
| # Add qiproject version to CMake | ||
| set(QI_SDK_VERSION %s CACHE STRING "" FORCE) |
Contributor
There was a problem hiding this comment.
I believe QI_SDK_ prefix is already used elsewhere.
Mabye use QI_PROJECT_VERSION instead ?
Changing cmake variable name from QI_SDK_VERSION to QI_PROJECT_VERSION.
vbarbaresi
reviewed
Oct 23, 2017
Contributor
vbarbaresi
left a comment
vbarbaresi
left a comment
There was a problem hiding this comment.
looks good to me, for good measure we should add some tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating the project.cmake file containing the project version number when
running qibuild configure. This file allows the use of the qiproject.xml
information in CMake. It is automatically included by the qibuild-config.cmake
in the same way than the dependencies.cmake.