Skip to content

Conversation

RezaRahemtola
Copy link
Member

When deleting an instance, the behavior for the ports-forwarding aggregate is different between the CLI and the UI:

The problem is that the types in the SDK (and thus in the CLI) don't expect an item hash in the ports-forwarding aggregate to be null (as you can see, I just added the possibility in this PR).

This means that if a user deletes an instance in the UI, then the CLI won't function properly anymore, as it will throw Pydantic parsing errors when fetching the ports, for example when deleting an instance:
image

Unfortunately the fix is probably not as simple as adding this line:

  • Adding the possibility of null ports may (well is according to the tests) break some stuff in the SDK / CLI so it should be done carefully
  • Updating the UI to avoid setting null values is also out of the question imo, as it won't solve the issue for existing users (and after a quick look at the UI, it's using a generic part of the code to delete the ports so it would need a bit more than a single line change too)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant