wip: test aleph-vm rewrite#24
Conversation
foxpatch-aleph
left a comment
There was a problem hiding this comment.
Trivially switches aleph-vm from pinned version 1.12.0 to a feature branch (od/wire-supervisor-abstraction) for testing. Follows the file's own documented convention for branch-based deployment. No correctness, security, or quality issues — a straightforward WIP configuration change.
manifesto.yml (line 38): Switches aleph-vm deployment from release v1.12.0 to branch od/wire-supervisor-abstraction for testing. Consistent with the file's documented pattern and the PR's own WIP status.
42aac54 to
3dfb050
Compare
foxpatch-aleph
left a comment
There was a problem hiding this comment.
This WIP PR switches the aleph-vm component from the released version 1.12.0 to the Git branch "od/wire-supervisor-abstraction" via the already-supported branch mechanism in manifesto.yml. The change is consistent with the existing documented workflow in the file comments. The supporting scripts (crn-up.sh, deploy.sh) handle both version and branch modes correctly: crn-up.sh's install_crn() checks for a branch first and only falls back to read_vm_version() when no branch is set, so the commented-out version key never causes a KeyError in practice. The change is minimal, follows the documented pattern, and is appropriate for a WIP branch deployment.
manifesto.yml (line 35): Note: read_vm_version() in scripts/crn-up.sh:65 would raise a KeyError if called with this manifesto, since the 'version' key is absent. This is safe in the current code path because install_crn() calls read_vm_branch() first and only calls read_vm_version() in the else branch — but it's a latent trap if someone adds a new caller. Consider making read_vm_version() use .get('version', '') or have it return an error instead of crashing.
foxpatch-aleph
left a comment
There was a problem hiding this comment.
Click Re-request review to retry.
No description provided.