Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement infinite scrolling for document search #3855

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Implement infinite scrolling for document search #3855

wants to merge 4 commits into from

Commits on Aug 25, 2024

  1. Split up render method in PdfViewerSearch 

    This is just a small refactoring to make it easier to adjust this method.
    @tillprochaska
    tillprochaska committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    43ab25b View commit details
    Browse the repository at this point in the history

  2. Rename fetchPage to fetchSearchResults 

    … because that is what it actually does -- it doesn’t load a page from the document, it loads a list of pages that contain the search terms.
    @tillprochaska
    tillprochaska committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    1655faf View commit details
    Browse the repository at this point in the history

  3. Implement infinite scrolling for document search results 

    Fixes #3320
    @tillprochaska
    tillprochaska committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    e3883a2 View commit details
    Browse the repository at this point in the history

  4. Remove useless code 

    I’m not sure what exactly the intention here was originally, but it didn’t have any effect in its current version. `page` and `res.index` would always be undefined and as a result, the `active` class was applied to every single link. The `active` class doesn’t apply any styles.

Probably this is just leftover from a previous iteration of the UI, so I’ve removed this.
    @tillprochaska
    tillprochaska committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    fb105f8 View commit details
    Browse the repository at this point in the history