Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revive examples page by fixing configuration issues #169

Merged
merged 1 commit into from
Mar 9, 2025

Conversation

wanaryytel
Copy link
Contributor

@wanaryytel wanaryytel commented Mar 7, 2025

This PR

  • fixes configuration issues that prevented examples from working before
    • @koale/useworker not linked correctly (still has to be built manually though)
    • wrong vite root directory in examples
    • calling tsc in examples workspace that doesn't use typescript
  • adds missing dependencies to examples
  • migrates from using react-toast-notifications to react-hot-toast because react-toast-notifications doesn't support react 18
  • fixes bubble sort typo :)

Copy link

pkg-pr-new bot commented Mar 7, 2025

Open in Stackblitz

npm i https://pkg.pr.new/alewin/useWorker/@koale/useworker@169

commit: d657027

@alewin
Copy link
Owner

alewin commented Mar 9, 2025

Excellent work! @wanaryytel 👏 thanks you

@alewin alewin merged commit 09ac8af into alewin:master Mar 9, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants