Added support for 'func' being a classmethod, with the 'klass' option. #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I only see this now, after implementing #136. I first had a similar approach than @ZackHodari but then I needed a method within a class of a class, and then the 'klass' attribute approach fails. So instead, I added support for hierarchical class.class.func kind of notation in #136. Sad to see this PR has received no feedback in 21 months :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
funcis a classmethod then it is not possible to use.. argparse::without adding python code to the source (which should not be necessary).The PR simply adds an option to specify the class (
klass).