Skip to content

Conversation

@pete-woods
Copy link
Contributor

@pete-woods pete-woods commented Apr 8, 2024

Add a CI config for the main module, and several of the store submodules.

It seems like the old Travis config only runs CI for the main module, and might not even be working any more? (Or at least I can't see any links to it in PRs).

You can see the workflow succeeding in my fork: https://github.com/pete-woods/scs/actions/runs/8602119100/job/23570922962

@pete-woods pete-woods marked this pull request as ready for review April 8, 2024 14:51
@pete-woods pete-woods force-pushed the setup-github-actions branch from bebda46 to a54816b Compare April 9, 2024 11:59
@pete-woods
Copy link
Contributor Author

pete-woods commented Jul 1, 2024

@alexedwards 👋 Hello - there's quite a few little PRs building up in this repo (not all of them mine). Is there any chance you have time to look at them? Is there anything we can do to help you review them?

I added this PR in particular to make it easier to run all the tests you have for things.

@pete-woods
Copy link
Contributor Author

@alexedwards Sorry to nag again, but is there any chance you have time to look at the PRs I've raised against this repo? Thanks!

@alexedwards
Copy link
Owner

@pete-woods Thanks for this. I'm going to merge it now, fingers crossed for a clean run 🤞

@alexedwards alexedwards merged commit 093344b into alexedwards:master Oct 1, 2025
@alexedwards
Copy link
Owner

@pete-woods Apart from needing to bump the Go version to 1.23 to support the Partitioned cookie attribute, this all worked perfectly. Thanks again 👍

@pete-woods
Copy link
Contributor Author

You're most welcome. You've reminded me to look at the other PR now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants