fix(cable): remove redundant quoting around {} in action commands#1048
Open
Mic92 wants to merge 1 commit intoalexpasmantier:mainfrom
Open
fix(cable): remove redundant quoting around {} in action commands#1048Mic92 wants to merge 1 commit intoalexpasmantier:mainfrom
Mic92 wants to merge 1 commit intoalexpasmantier:mainfrom
Conversation
Since format_command() already wraps each entry in single quotes when
substituting a bare {} placeholder, having '{}' in the channel config
results in ''entry'' which the shell parses as an unquoted string.
This breaks any action on entries containing spaces, e.g. in the
downloads, dirs, files and zoxide channels:
rm: cannot remove '/home/user/Downloads/Ethereum': No such file or directory
rm: cannot remove 'Flakes.pdf': No such file or directory
Preview commands are unaffected as they use a different code path
(Template::format) without auto-quoting, so those keep their explicit
quotes.
Fixes alexpasmantier#976
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
format_command()already wraps each entry in single quotes when substituting a bare{}placeholder, having'{}'in the channel config results in''entry'', which the shell parses as an unquoted string. This breaks any action on entries containing spaces, e.g. in thedownloads,dirs,filesandzoxidechannels:Preview commands are left untouched since they go through
Template::formatwhich does not auto-quote.Fixes #976