-
Notifications
You must be signed in to change notification settings - Fork 80
PR requirements
Martin Algesten edited this page Jan 12, 2026
·
2 revisions
This page describes what is required to land a PR in str0m without it being altered by maintainers.
The CI must pass cleanly. A single GitHub Action runs all checks including:
- Tests
- Clippy
- Rustfmt
- Documentation
- A project member must leave an approving review
- All review comments must be resolved
Update CHANGELOG.md with a short entry describing the change:
- Add
(breaking)if it introduces breaking changes - Entries are sorted in reverse order of PR landing (newest at top)
- Squash to a single commit including the
CHANGELOG.mdchange - Rebase off latest main
- Keep the first line short (80-90 characters)
- Omit PR numbers
- Only include a body if it genuinely provides additional information not already in the PR
If the PR addresses an issue, include Closes #<issue> in the PR description.
New features must include:
- Unit tests
- Integration tests
If a PR does not follow these rules, maintainers may edit/push additional commits or use GitHub's squash button.