Skip to content

Conversation

ben-kalmus
Copy link
Contributor

@ben-kalmus ben-kalmus commented Sep 9, 2025

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/CMP-533

Changes included:

  • Update compositions tests with latest features:
    • metadata on compositions injections
    • external injection

🧪 Test

CI

@ben-kalmus ben-kalmus changed the title update metadata and external injection tests test(compositions): update metadata and external injection testcases Sep 9, 2025
@algolia-bot
Copy link
Collaborator

algolia-bot commented Sep 9, 2025

✔️ Code generated!

Name Link
🪓 Triggered by 2bdda6023639f5c11eaf104c5968255265f4696b
🍃 Generated commit 11f6dd15176aaa89569df1699fee321d444a5d8c
🌲 Generated branch generated/benk/update-compositions-tests
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 1793
javascript 1659
php 1460
csharp 1330
python 1141
java 984
ruby 800
swift 338
scala 23

@ben-kalmus ben-kalmus changed the title test(compositions): update metadata and external injection testcases test: update compositions testcases for metadata and external injected items Sep 9, 2025
@ben-kalmus ben-kalmus force-pushed the benk/update-compositions-tests branch from f065e8c to 6f9eb00 Compare September 9, 2025 08:17
@ben-kalmus ben-kalmus changed the title test: update compositions testcases for metadata and external injected items test(javascript): update compositions testcases for metadata and external injected items Sep 9, 2025
@ben-kalmus ben-kalmus force-pushed the benk/update-compositions-tests branch 2 times, most recently from fb18e3c to f7a098e Compare September 9, 2025 09:20
@ben-kalmus ben-kalmus marked this pull request as ready for review September 10, 2025 14:10
@ben-kalmus ben-kalmus requested a review from a team as a code owner September 10, 2025 14:10
@ben-kalmus ben-kalmus force-pushed the benk/update-compositions-tests branch from bf99dab to be1ca1f Compare September 11, 2025 09:40
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@shortcuts shortcuts merged commit 67a3abd into main Sep 11, 2025
29 checks passed
@shortcuts shortcuts deleted the benk/update-compositions-tests branch September 11, 2025 11:11
algolia-bot added a commit that referenced this pull request Sep 11, 2025
…rnal injected items (#5331) (generated) [skip ci]

Co-authored-by: Ben Kalmus <[email protected]>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Sep 11, 2025
…rnal injected items (generated)

algolia/api-clients-automation#5331

Co-authored-by: algolia-bot <[email protected]>
Co-authored-by: Ben Kalmus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants