[Week 7] 황주희 #28
Open
[Week 7] 황주희 #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Happhee
reviewed
Jun 8, 2022
Comment on lines
+2
to
+7
| let answer = []; | ||
|
|
||
| let score = [ 0, 0, 0] | ||
| let supo1 = [1,2,3,4,5] | ||
| let supo2 = [2,1,2,3,2,4,2,5] | ||
| let supo3 = [3,3,1,1,2,2,4,4,5,5] |
There was a problem hiding this comment.
요런 배열은 const로 선언하는게 조아여!!! 안전하게~.~
그른데 이제 제안할수 있는거느은 supo1,supo2, supo3보다는 supo로 하나의 배열 사용해서 이차원 쓸수도 있다아~.~
Happhee
reviewed
Jun 8, 2022
| let supo3 = [3,3,1,1,2,2,4,4,5,5] | ||
|
|
||
|
|
||
| for (var i = 0; i < answers.length; i++){ |
| } | ||
| } | ||
|
|
||
| let max_score = Math.max(...score) |
There was a problem hiding this comment.
변수이름은 !! lowerCamelCase 로!
maxScore
요기서는 값이 변하지 않으니까 const로 쓰면 데게쮸?!
Comment on lines
+11
to
+23
| if (supo1[i] === answers[i]) score[0]++ | ||
| if (supo2[i] === answers[i]) score[1]++ | ||
| if (supo3[i] === answers[i]) score[2]++ | ||
|
|
||
| if (i > supo1.length-1) { | ||
| if(supo1[i%supo1.length] === answers[i]) score[0]++ | ||
| } | ||
| if (i > supo2.length-1) { | ||
| if(supo2[i%supo2.length] === answers[i]) score[1]++ | ||
| } | ||
| if (i > supo3.length-1) { | ||
| if(supo3[i%supo3.length] === answers[i]) score[2]++ | ||
| } |
There was a problem hiding this comment.
그렇게 되면 요기 코드 반복되는 부분들을 줄일 수도 있겟져?!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ 푼 문제