Offsite-tuning model generation #676
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rayrayraykk
reviewed
Aug 16, 2023
Collaborator
rayrayraykk
left a comment
rayrayraykk
left a comment
There was a problem hiding this comment.
Please see the inline comments. Thx!
| else: | ||
| try: | ||
| ckpt = torch.load(config.federate.save_to, map_location='cpu') | ||
| self.prefix = [''] |
Collaborator
There was a problem hiding this comment.
Should prefix be passed by the config?
| # No need for this attr | ||
| if hasattr(adap_model, 'teacher'): | ||
| import gc | ||
| import torch |
Collaborator
There was a problem hiding this comment.
How about move line 48-49 to top:
try:
import gc
import torch
except ImportError:
gc=None
torch=None
| new_model = set_layers(new_model, emulator_and_adapter) | ||
|
|
||
| if emulator_alignment: | ||
| new_model.student = layers |
Collaborator
There was a problem hiding this comment.
Please merge the latest commits in which bugs are fixed. (layers should be detached from new_model)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two main updates: