Skip to content

fix(plugins/metric_system_v2): report fd metrics as string to avoid float64 precision loss #2487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zhang-guodong wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(plugins/metric_system_v2): report fd metrics as string to avoid float64 precision loss #2487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions plugins/input/systemv2/input_system_linux.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ import (
"bytes"
"io"
"os"
"strconv"
"strings"

"github.com/alibaba/ilogtail/pkg/helper/containercenter"
Expand Down Expand Up @@ -163,10 +162,8 @@ func (r *InputSystem) CollectOpenFD(collector pipeline.Collector) {
logger.Warning(r.context.GetRuntimeContext(), "FILENR_PATTERN_ALARM", "want", 3, "got", len(parts))
return
}
allocated, _ := strconv.ParseFloat(string(parts[0]), 64)
maximum, _ := strconv.ParseFloat(string(parts[2]), 64)
r.addMetric(collector, "fd_allocated", &r.commonLabels, allocated)
r.addMetric(collector, "fd_max", &r.commonLabels, maximum)
r.addMetricStringVal(collector, "fd_allocated", &r.commonLabels, string(parts[0]))
r.addMetricStringVal(collector, "fd_max", &r.commonLabels, string(parts[2]))
}

// CollectDiskUsage use `/proc/1/mounts` to find the device rather than `proc/self/mounts`
Expand Down
4 changes: 4 additions & 0 deletions plugins/input/systemv2/input_system_v2.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,10 @@ func (r *InputSystem) addMetric(collector pipeline.Collector, name string, label
collector.AddRawLog(helper.NewMetricLog(name, r.collectTime.UnixNano(), value, labels))
}

func (r *InputSystem) addMetricStringVal(collector pipeline.Collector, name string, labels *helper.MetricLabels, value string) {
collector.AddRawLog(helper.NewMetricLogStringVal(name, r.collectTime.UnixNano(), value, labels))
}

func (r *InputSystem) CollectCore(collector pipeline.Collector) {

// host info
Expand Down
Loading