resource/alicloud_kvstore_instance: unmark node_type as deprecated since classic instances still require it - #10416
Open
api-tool-agent wants to merge 1 commit into
Conversation
The node_type field was marked Deprecated since v1.120.1, but the CreateInstance API still requires NodeType for classic instances. When users follow the deprecation hint and omit node_type, NodeType is not sent in the Create request and the API rejects the creation. Remove the Deprecated marker and clarify in docs that classic instances must set node_type to double or single.
api-tool-agent
force-pushed
the
fix/65370478-nodetype-deprecated
branch
from
September 6, 2026 12:17
86836a2 to
a106f90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
The
node_typefield ofalicloud_kvstore_instancewas markedDeprecatedsince provider v1.120.1. However, the CreateInstance API still requiresNodeTypefor classic (non-cloud-native) instances. When users follow the deprecation hint and omitnode_type,NodeTypeis not sent in the Create request and the API rejects the creation.This PR:
Deprecatedmarker from thenode_typeschema so users are no longer told to omit a field that is still required.node_typemust be set todoubleorsingle, and for cloud native instances toMASTER_SLAVEorSTAND_ALONE.Why
node_typeis still a functional, API-required parameter for classic Redis instances. Marking it deprecated misled users into omitting it, causing instance creation failures.Tests
Remote acceptance tests will follow once CI is green.