-
Notifications
You must be signed in to change notification settings - Fork 0
[pfc] Http Cache-Control Validation #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
TestCheck cache control values with curl -I option from originGet the file in cache with proxy forwardingCheck saved cache-control attributes as file system xattr in the cinfo file |
osschar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass, I was also remembering things as I went so maybe some comments are silly.
|
|
||
|
|
||
| //------------------------------------------------------------------------------ | ||
| //! Perform an fcntl() operation (defaults to passthrough). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this documentation needs to be changed, it is mostly copy of Fstat.
i'm not sure if saying that it defaults to passthrough makes sense ... we need to see if there will be some Fcntl calls that need to be handled by the cache / open-file / IO.
src/XrdPfc/XrdPfc.cc
Outdated
| XrdCl::QueryCode::Code queryCode = XrdCl::QueryCode::XAttr; | ||
| XrdCl::Buffer queryArgs(5); | ||
| std::string qs = std::to_string(queryCode); | ||
| queryArgs.FromString(qs); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why does it have to go to-string and then from-string? it's internal XrdCl enum/int.
…ibutes when file does not exist in cache yet.
This code adds cache-control check using File::Fctnl and FileSystem::Query.
The change is related to pelican-client code PelicanPlatform/xrdcl-pelican#59