Moves LayerNorm to output of the Encoder's sub-layers#47
Open
patrickgadd wants to merge 1 commit intoallegro:masterfrom
Open
Moves LayerNorm to output of the Encoder's sub-layers#47patrickgadd wants to merge 1 commit intoallegro:masterfrom
patrickgadd wants to merge 1 commit intoallegro:masterfrom
Conversation
Contributor
|
please see my response in #46 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
As explained in #46, I believe that there is a minor lack of correspondence between the implementation and what's written in the paper ("Context-Aware Learning to Rank with Self-Attention") when it comes to the Transformer architecture.
Sadly I can't say whether this in practice affects performance, as I'm attempting to utilize this work for something entirely different.
However, it looks like that with the fix, learning is a tad more stable.
At any rate, thank you once again for this work and publishing it!