Skip to content

Conversation

@hamishivi
Copy link
Collaborator

@hamishivi hamishivi commented Oct 19, 2025

Removing old code from the RL-rag project. This is not needed on main and no longer even used.

Part of me breaking up the big tool refactor PR (#1086)

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @hamishivi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a significant cleanup of the codebase by removing outdated and unused components specifically related to the RL-rag project. The deleted files encompass various evaluation scripts and a core search actor implementation, which are no longer necessary for the main branch. This action streamlines the project, reduces code clutter, and improves overall maintainability.

Highlights

  • Removal of RL-rag Evaluation Scripts: Several shell and Python scripts previously used for evaluating RL-rag models, including analyse_existing_results.sh, calculate_doc_recall.py, gpqa_eval.py, naive_rag_baseline_eval.py, run_short_form_qa_eval_naive_rag.sh, and run_short_form_qa_eval_toolvllm.sh, have been completely removed.
  • Deletion of LLM Search Ray Actor: The search_actor.py file, which contained the LLMSearchRayActor responsible for iterative generation with search capabilities, has been deleted as it is no longer in use.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes several files related to the old rl-rag project, which is a good cleanup effort. However, the removal seems to be incomplete as a script scripts/train/rl-rag/eval.sh still references one of the deleted files, open_instruct/search_utils/gpqa_eval.py. This will break the script. I've left a specific comment on the deleted file. Please address this to ensure a clean removal.

Copy link
Collaborator

@finbarrtimbers finbarrtimbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BAM! Might be a new record for open-instruct deletion!

@hamishivi hamishivi added this pull request to the merge queue Oct 19, 2025
Merged via the queue into main with commit 59233d8 Oct 19, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants