-
Notifications
You must be signed in to change notification settings - Fork 453
Updated filtering for identity #1113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @natolambert, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly upgrades the dataset filtering script, Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the keyword filtering logic to better identify and remove model identity mentions from datasets. The changes include adding more providers and regex patterns, making the message column configurable, and improving performance by enabling parallel processing. My review identified a critical bug that prevents the correct display of filtered examples, a contradiction in a regex comment, and some opportunities to improve code clarity and remove redundancy. Addressing these points will improve the correctness and maintainability of the script.
scripts/data/filtering_and_updates/filter_dataset_by_keywords.py
Outdated
Show resolved
Hide resolved
scripts/data/filtering_and_updates/filter_dataset_by_keywords.py
Outdated
Show resolved
Hide resolved
scripts/data/filtering_and_updates/filter_dataset_by_keywords.py
Outdated
Show resolved
Hide resolved
scripts/data/filtering_and_updates/filter_dataset_by_keywords.py
Outdated
Show resolved
Hide resolved
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
scripts/data/filtering_and_updates/filter_dataset_by_keywords.py
Outdated
Show resolved
Hide resolved
Updated regex patterns for filtering AI model mentions and improved dataset filtering logic.
| if len(dataset) > len(filtered_dataset): | ||
| print("\nCollecting example filtered instances...") | ||
| examples_found = 0 | ||
| print_within = min(10000, len(dataset)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| print_within = min(10000, len(dataset)) | |
| print_within = min(1000, len(dataset)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Note
Broaden identity-provider filtering patterns, add column-aware filtering, and speed up load/filter/upload with caching disabled and parallel processing.
PROVIDERSwith"ChatGPT"and add new regexes (e.g., "I am called", direct "I'm/I am ") with bounded matches; broaden patterns forDeepSeek,Qwen, andAlibabamentions.column-aware filtering (example[column]) and treatNonecontent as removable.--columnarg; update usage path in script header.HF_DATASETS_DISABLE_CACHING,disable_caching()).push_to_hubwithnum_proc; add parquet fallback loader.Written by Cursor Bugbot for commit b677b24. This will update automatically on new commits. Configure here.