Skip to content

Conversation

@SauravMaheshkar
Copy link
Contributor

@SauravMaheshkar SauravMaheshkar commented May 5, 2023

Follow up of #558

Request for Review: @epwalsh

Copy link
Member

@epwalsh epwalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SauravMaheshkar! Looks like the ruff configuration needs a fix

@SauravMaheshkar SauravMaheshkar requested a review from epwalsh May 10, 2023 14:30
@SauravMaheshkar
Copy link
Contributor Author

Are the failing tests related to this PR ??

@epwalsh
Copy link
Member

epwalsh commented May 10, 2023

Are the failing tests related to this PR ??

I don't think so. W&B, Beaker, GS, and GPU Tests are failing due to missing permissions (which is expected), and I'm guessing the PyTorch tests will be resolved by #560. I'll hold off until #560 merges since Dirk is working on that right now.

Copy link
Member

@epwalsh epwalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@epwalsh epwalsh merged commit 4c3edce into allenai:main Jun 12, 2023
@SauravMaheshkar SauravMaheshkar deleted the ruff branch June 12, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants