Skip to content

bugfix: reverted navigation arrows #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

bugfix: reverted navigation arrows #316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f6aef4
bugfix: reverted navigation arrows
garaichinar-cyber Oct 8, 2025
204fc01
add e2e test to verify navigation directions using arrows
garaichinar-cyber Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions packages/e2e/test/allure-awesome/test/testResult.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,30 @@ test.describe("allure-awesome", () => {
await expect(testResultPage.titleLocator).toHaveText(testTitleText);
});

test("navigation arrows navigate in the expected direction between test results", async () => {
await treePage.clickNthLeaf(0);

const startingPageIndex = 1;
let navCounterText = await testResultPage.navCurrentLocator.textContent();
const navStartingPageNumber = Number(navCounterText?.split("/")[0]);

let isPressBackButtonDisabled = await testResultPage.navPrevLocator.isDisabled();
expect(isPressBackButtonDisabled).toBe(true);

expect(navStartingPageNumber).toEqual(startingPageIndex);
await testResultPage.clickNextTestResult();

navCounterText = await testResultPage.navCurrentLocator.textContent();
const navNextPageNumber = Number(navCounterText?.split("/")[0]);
expect(navNextPageNumber).toEqual(startingPageIndex + 1);

await testResultPage.clickPrevTestResult();

navCounterText = await testResultPage.navCurrentLocator.textContent();
const navPreviousPageNumber = Number(navCounterText?.split("/")[0]);
expect(navPreviousPageNumber).toEqual(startingPageIndex);
});

test("test result fullname copies to clipboard", async ({ browserName, page, context }) => {
test.skip(browserName !== "chromium", "Only chromium supports clipboard API");

Expand Down
8 changes: 4 additions & 4 deletions packages/web-awesome/src/components/TestResult/TrNavigation/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,10 @@ export const TrNavigation: FunctionalComponent<TrNavigationProps> = ({ testResul
<IconButton
icon={allureIcons.lineArrowsChevronDown}
style={"ghost"}
isDisabled={currentIndex === data.length}
isDisabled={currentIndex <= 1}
data-testid="test-result-nav-prev"
className={styles["test-result-nav-prev"]}
onClick={() => navigateTo(data[currentIndex])}
onClick={() => navigateTo(data[currentIndex - 2])}
/>
</TooltipWrapper>
<Code
Expand All @@ -66,9 +66,9 @@ export const TrNavigation: FunctionalComponent<TrNavigationProps> = ({ testResul
<IconButton
icon={allureIcons.lineArrowsChevronDown}
style={"ghost"}
isDisabled={currentIndex <= 1}
isDisabled={currentIndex === data.length}
data-testid="test-result-nav-next"
onClick={() => navigateTo(data[currentIndex - 2])}
onClick={() => navigateTo(data[currentIndex])}
/>
</TooltipWrapper>
</div>
Expand Down
8 changes: 4 additions & 4 deletions packages/web-classic/src/components/TestResult/TestResultNavigation/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,10 @@ export const TestResultNavigation: FunctionalComponent<TestResultNavigationProps
<IconButton
icon={allureIcons.lineArrowsChevronDown}
style={"ghost"}
isDisabled={currentIndex === data.length}
isDisabled={currentIndex <= 1}
data-testid="test-result-nav-prev"
className={styles["test-result-nav-prev"]}
onClick={() => navigateTo(data[currentIndex])}
onClick={() => navigateTo(data[currentIndex-2])}
/>
</TooltipWrapper>
<Code
Expand All @@ -65,9 +65,9 @@ export const TestResultNavigation: FunctionalComponent<TestResultNavigationProps
<IconButton
icon={allureIcons.lineArrowsChevronDown}
style={"ghost"}
isDisabled={currentIndex <= 1}
isDisabled={currentIndex === data.length}
data-testid="test-result-nav-next"
onClick={() => navigateTo(data[currentIndex - 2])}
onClick={() => navigateTo(data[currentIndex])}
/>
</TooltipWrapper>
</div>
Expand Down