This repository was archived by the owner on Jan 18, 2025. It is now read-only.
Sorting new feature#356
Open
ekarudianto wants to merge 5 commits intoalmende:masterfrom
ekarudianto:sorting-new-feature
Open
Sorting new feature#356ekarudianto wants to merge 5 commits intoalmende:masterfrom ekarudianto:sorting-new-feature
ekarudianto wants to merge 5 commits intoalmende:masterfrom
ekarudianto:sorting-new-feature
Conversation
…he sortableType is date, remove case sensitive
Contributor
|
Good point, thanks. The sorting now always orders by string value. I think your solution is nice but we can implement a more generic solution by allowing people to provide their own comparator. This allows you to create a custom compare function for every sort of data, not just number, string, and Date. It should be possible to configure a comparator for each individual column. As for your specific use case: it may be better to provide the date |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found a bug when I do a sorting based on date, it doesn't sorted out right because it's sorted based on string.. I manage to made a workaround by adding new option which is
sortableType
the default value would be "string" but it could be a date as well.. and also I remove the sorting case sensitive by converting all the strings into lower case
I reallly hope this helps you Jos ! and please review my code if you have time and see if I missed something :)