permutation iterator, not thoroughly checked yet #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimeonEhrig
reviewed
Jan 25, 2022
| << "Testing permutation iterator with value: 10\n"; | ||
| //*/ | ||
|
|
||
| std::vector<TRed> values{ 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20 }; |
There was a problem hiding this comment.
values and indices should be alpaka memory buffers or pointers to the buffers.
| // Get a queue on the accelerator device. | ||
| QueueAcc queueAcc(devAcc); | ||
|
|
||
| typedef std::vector<TRed> element_range_type; |
There was a problem hiding this comment.
Please use using instead typedef.
| */ | ||
| NODISCARD ALPAKA_FN_INLINE reference operator*() const | ||
| { | ||
| return *(elIter + *idxIter); |
There was a problem hiding this comment.
The access should be elIter[idxIter[idx]]]. Don't forget to check the size of idxIter.
| /** | ||
| * @brief Index operator to get stored value at some given offset from this iterator | ||
| */ | ||
| NODISCARD ALPAKA_FN_INLINE reference operator[](int _idx) |
There was a problem hiding this comment.
operator[] does not change the own index.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.